[PATCH] D116139: [ORC-RT] Add debug logging macros.

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D116139#3229089 <https://reviews.llvm.org/D116139#3229089>, @lhames wrote:

> In D116139#3220124 <https://reviews.llvm.org/D116139#3220124>, @benlangmuir wrote:
>
>> Handling "" as enabling all logging is a bit strange to me -- what was the reasoning for that? LGTM other than than the return value from `initializeDebug` that I mentioned.
>
> Defining ORC_RT_DEBUG to empty is an odd corner case. I don't know whether having it equivalent to "all" or "none" makes more sense. I've switched it to "none" for the commit, but no strong feelings either way.

FWIW, I think empty should match "none" (the new behaviour after the update). In shell scripts, unset and empty are often used interchangeably (e.g., using `[ -z "$VAR" ]` rather than spelling out `[ -z "${VAR:-}" ]`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116139/new/

https://reviews.llvm.org/D116139