[PATCH] D111416: [Demangle] Add minimal support for D simple basic types

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D111416#3223399 <https://reviews.llvm.org/D111416#3223399>, @ljmf00 wrote:

> @dblaikie I removed all the uncovered types and added just minimal support just to prove type parsing functionality. I change the name of the patch to reflect the changes. I still have `Demangled << "int";` and `Demangled << "void";` that are covered but with untested behaviour. I can add a comment explaining why or remove it completely if you prefer.

Yeah, I think best to remove them for now - introduce them when they're testable. Not sure what the minimal functionality si for now - if you need one of them, but to do nothing, could just have "case 'v': ++Mangled; return Mangled;" or the like.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111416/new/

https://reviews.llvm.org/D111416