[PATCH] D116855: Add 'eager-checks' as a module parameter to MSAN.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 17:30:09 PST 2022


vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:701-703
+  OS << "track-origins=" << Options.TrackOrigins << ";";
+  if (Options.EagerChecks)
+    OS << "eager-checks;";
----------------
This breaks existing new-pm-print-pipeline.ll test for me (check-llvm)
Maybe flip like this to avoid ; before >

Please add something for EagerChecks into new-pm-print-pipeline.ll as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116855/new/

https://reviews.llvm.org/D116855



More information about the llvm-commits mailing list