[PATCH] D116871: [llvm-reduce] optionally keep running delta passes until they stop making the IR smaller

[John Regehr via Phabricator via llvm-commits]

regehr added inline comments.


================
Comment at: llvm/tools/llvm-reduce/DeltaManager.cpp:110
+  Tester.getProgram().print(SS, /*AnnotationWriter=*/nullptr);
+  return SS.str().length();
+}
----------------
aeubanks wrote:
> not the greatest metric, perhaps add a FIXME for a better metric?
thanks for the review! 

I'll add this fixme. I really don't have a better idea here. size of the textual IR is definitely a bit weird, but it has the advantage of encompassing all parts of the serialized IR. simpler metricss like counting instructions would fail to account for removing globals, metadata, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116871/new/

https://reviews.llvm.org/D116871