[PATCH] D116771: [RISCV] Add DAG combine to fold (fp_to_int (ffloor X)) -> (fcvt X, rdn)

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 13:18:08 PST 2022


asb added a comment.

LGTM, modulo one comment.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:7058
+
+  // Don't do this for f16 with Zfhmin and not Zfh.
+  if (Src.getValueType() == MVT::f16 && !Subtarget.hasStdExtZfh())
----------------
Is it possible to add some test coverage for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116771/new/

https://reviews.llvm.org/D116771



More information about the llvm-commits mailing list