[PATCH] D116964: [NFC][MLGO] Use LazyCallGraph::Node to track functions.

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 11:33:55 PST 2022


aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:408
 
 size_t DevelopmentModeMLInlineAdvisor::getTotalSizeEstimate() {
   if (!InlineSizeEstimatorAnalysis::isEvaluatorRequested())
----------------
AFAICT, this is only called in the constructor of `DevelopmentModeMLInlineAdvisor` where we shouldn't have any deleted functions. and `isFunctionDeleted()` is only referenced here. is `isFunctionDeleted()` still necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116964/new/

https://reviews.llvm.org/D116964



More information about the llvm-commits mailing list