[PATCH] D116725: [VP] llvm.vp.merge intrinsic and LangRef

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/docs/LangRef.rst:17882
+The first operand is a vector of ``i1`` and indicates the condition.  The
+second operand is the value that is mergeed where the condition vector is true.
+The third operand is the value that is selected where the condition vector is
----------------
mergeed->merged


================
Comment at: llvm/docs/LangRef.rst:17899
+
+For all lanes below ``%evl`` where the condition vector is true and the lane
+position is less than ``pivot`` the lane is taken from the second operand.
----------------
You've used %pivot in the IR below.


================
Comment at: llvm/docs/LangRef.rst:17900
+For all lanes below ``%evl`` where the condition vector is true and the lane
+position is less than ``pivot`` the lane is taken from the second operand.
+Otherwise, the lane is taken from the third operand.
----------------
This paragraph is written as if there two operands evl and pivot.


================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:352
 
+// llvm.vp.select(mask,on_true,on_false,pivot)
+BEGIN_REGISTER_VP(vp_merge, 0, 3, VP_MERGE, -1)
----------------
vp.select->vp.merge


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116725/new/

https://reviews.llvm.org/D116725