[PATCH] D116441: [AMDGPU][GlobalISel] Select op_sel modifiers for VOP3P

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 09:40:04 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3395
+
+static Register stripExtract(const MachineRegisterInfo &MRI, Register Src) {
+  if (MRI.getType(Src).getSizeInBits() != 32)
----------------
Is this really necessary given that we're generally moving away from using G_EXTRACT at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116441/new/

https://reviews.llvm.org/D116441



More information about the llvm-commits mailing list