[PATCH] D116766: [SCEV] Sequential/in-order `UMin` expression
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 10 09:12:53 PST 2022
nikic added a comment.
In D116766#3231777 <https://reviews.llvm.org/D116766#3231777>, @reames wrote:
> I skimmed the code for a sanity check, but am mostly just commenting on the high level bits.
>
> I'm not convinced this is the right approach, but I also don't want to block iterative progress. My primary concern is that I don't see how this solves the multiple exit case and that I think we're going to end up needing a new representation there, which indirectly solves this problem. However, I think we can work step-wise here, and come back to refactor/clean this up if needed.
Why do you think this would't solve the multiple exit case? The new node is currently not used for that case, but I do believe it would address that case as well (if used).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116766/new/
https://reviews.llvm.org/D116766
More information about the llvm-commits
mailing list