[PATCH] D116943: AMDGPU/GlobalISel: Explicitly track d16 for image legalization

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne accepted this revision.
sebastian-ne added a comment.
This revision is now accepted and ready to land.

Looks good to me, the code looks a lot better than before.

Having a float image store with dmask=15 sounds bad. What happens if the load/store is assigned the last allocated register? I.e.

  ; Shader allocates v[0:63]
  image_store v63, v[1:2], s[0:7] dmask:0xf dim:SQ_RSRC_IMG_2D unorm

Will the hardware try to read v64–v66 and hang because they are not allocated?
(I remember there was an issue with d16 and the hardware incorrectly computing the register requirement, but not sure if that leads to hangs or values getting lost.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116943/new/

https://reviews.llvm.org/D116943