[PATCH] D116566: [flang] Fix the documentation on how to build flang

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 07:37:34 PST 2022


rovka added inline comments.


================
Comment at: flang/README.md:101
+To do the standalone build, start the same way by cloning the source for
+llvm-project:
+```bash
----------------
I have 2 mostly orthogonal comments here:

1. People might skip directly to this section and then be surprised a few lines down when you mention the in tree build. I think this paragraph should make it clear from the start that you're expected to go through the previous section first. We should probably also mention that if you're building standalone you no longer need to include flang in LLVM_ENABLE_PROJECTS for the in tree build (otherwise people will end up building flang twice when they're really only interested in the standalone one).

2. Do we really need to clone again? It should work to just point cmake to the flang subdirectory inside the first clone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116566/new/

https://reviews.llvm.org/D116566



More information about the llvm-commits mailing list