[PATCH] D116838: [ELF] -Map --why-extract=: print despite errors

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Presumably the relocation error is detected early, and not one detected late during writeTo()? I suspect that a late error would lead to a more complete map file being produced. In Arm's proprietary linker the ability to write a map file when a relocation out of range error has been detected has been really useful to debug problems in the thunk creation logic. I think it should be possible to detect if the OutputSections are incomplete, if that is the case it may be worth suppressing the OutputSections in the map file, or maybe putting a warning in the map file to state that output is incomplete.

Definitely support the idea of outputting as much diagnostics as possible, even when there is an error though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116838/new/

https://reviews.llvm.org/D116838