[PATCH] D115449: [Dexter] Allow DexUnreachable to be specified in supplementary .dex files

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py:22-23
+def have_hit_line(watch, loc):
+  if watch.lineno == loc.lineno:
+    return True
+  elif hasattr(watch, '_on_line') and watch._on_line == loc.lineno:
----------------
Orlando wrote:
> Shouldn't this check come last? Otherwise IIUC this will return True when the positional line number of the command is hit, even when a line argument is specified.
Good catch, I've updating this condition and added a test for that scenario (unreachable_not_cmd_lineno.cpp)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115449/new/

https://reviews.llvm.org/D115449