[PATCH] D116714: AMDGPU: Fix LiveVariables error after optimizing VGPR ranges

[Ruiling, Song via Phabricator via llvm-commits]

ruiling added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:389
 
   for (MachineBasicBlock *MBB : depth_first_ext(ThenEntry, Visited)) {
     if (MBB == Flow)
----------------
A pre-order walk over the blocks should more match the need here. the dfs walk does not work if we meet `Flow` block first, thus skipping some blocks in the THEN region. Using "continue" will make the traversal going all the way to the return block of the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116714/new/

https://reviews.llvm.org/D116714