[PATCH] D116851: [MemoryBuiltins] Add field for alignment argument

[Bryce Wilson via Phabricator via llvm-commits]

Bryce-MW added a comment.

I am assuming that I don't have commit access since this is my first contribution so I would appreciate you landing the changes outside of Attributor.

I agree that someone experienced with Attributor should look at it to be sure. Looking at it again, I think that it probably does assume that it is constant and while I could put in a check, I'm not sure if there is a way to back out if it was not (maybe this was an issue even with the original aligned_alloc?). getAssumedConstant will return nullptr if it is sure that the value is not constant. getAPInt will return none if the result from getAssumedConstant is neither a known constant nor none (unsure if constant or not). The like after the line I changed then asserts that the result from getAPInt has a value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116851/new/

https://reviews.llvm.org/D116851