[PATCH] D116890: [RISCV] Add initial support for getRegUsageForType and getNumberOfRegisters

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:132
+      return 64;
+    else if (HasStdExtF)
+      return 32;
----------------
No else after return


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:283
+InstructionCost RISCVTTIImpl::getRegUsageForType(Type *Ty) const {
+  auto Size = Ty->getPrimitiveSizeInBits();
+  if (Ty->isVectorTy()) {
----------------
Don't use auto


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:287
+      return divideCeil(Size.getKnownMinValue(), RISCV::RVVBitsPerBlock);
+    else if (ST->useRVVForFixedLengthVectors())
+      return divideCeil(Size, ST->getMinRVVVectorSizeInBits());
----------------
No else after return


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:291
+
+  auto FLen = ST->getFLen();
+  if (FLen && Ty->isFloatingPointTy()) {
----------------
Don't use auto


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:292
+  auto FLen = ST->getFLen();
+  if (FLen && Ty->isFloatingPointTy()) {
+    return divideCeil(Size, FLen);
----------------
Drop curly braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116890/new/

https://reviews.llvm.org/D116890