[PATCH] D116851: [MemoryBuiltins] Add field for alignment argument

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

I'd suggest leaving the Attributor change to it's own review.  I'm not familiar enough to review it easily.  Let's get the allocation accessor in, and then iterate.



================
Comment at: llvm/lib/Analysis/MemoryBuiltins.cpp:278
+  }
+  return V->getOperand(FnData->AlignParam);
+}
----------------
Er, this does not work.  You need to check that AlignmentParam is not -1, or this will crash.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116851/new/

https://reviews.llvm.org/D116851