[PATCH] D116851: [MemoryBuiltins] Add field for alignment argument

[Bryce Wilson via Phabricator via llvm-commits]

Bryce-MW marked 2 inline comments as done.
Bryce-MW added a comment.

Thanks for the suggestions! I had a feeling that there would be a better way than passing indexes around. I think I've mostly implemented them correctly. I'm not entirely sure if my use of getInitialValueOfAllocation is correct. I am also not sure about the part where getAllocSize has the possibility of creating a multiplication. Maybe that should return a pair of Values and let the caller create a multiplication if it wants?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116851/new/

https://reviews.llvm.org/D116851