[PATCH] D116668: libclc: Add clspv64 target

[Jan Vesely via Phabricator via llvm-commits]

jvesely requested changes to this revision.
jvesely added a comment.
This revision now requires changes to proceed.

Was this tested on an existing device, or is it just for completion (since there already is clspv target)?



================
Comment at: libclc/CMakeLists.txt:221
+	if ( NOT ${ARCH} STREQUAL spirv AND NOT ${ARCH} STREQUAL spirv64 AND NOT
+            ${ARCH} STREQUAL clspv AND NOT ${ARCH} STREQUAL clspv64)
 		LIST( APPEND dirs generic )
----------------
wrong formatting. If you spill over to the next line keep NOT close to the negated element and align to match the first line


================
Comment at: libclc/CMakeLists.txt:253
+	if( NOT ${ARCH} STREQUAL "spirv" AND NOT ${ARCH} STREQUAL "spirv64" AND
+            NOT ${ARCH} STREQUAL "clspv" AND NOT ${ARCH} STREQUAL "clspv64" )
 		set( rel_files convert.cl )
----------------
formatting issue


================
Comment at: libclc/CMakeLists.txt:308
+				set( t "spir64--" )
+			endif()
 			set( build_flags )
----------------
just add another `elseif` branch for better readability. Nested if is not saving much


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116668/new/

https://reviews.llvm.org/D116668