[PATCH] D116852: bugfix: bpf: DATASEC names might be wrong in the BTF data

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 8 03:14:06 PST 2022


RKSimon added a comment.

We need some kind of test coverage.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:590
+  ((GlobalVariable *) GV)->setSection(TheSection->getName());
+
   // If we have a bss global going to a section that supports the
----------------
I'm not very familiar with this code, but altering const variables like this doesn't seem like a good idea - is there any kind of existing 'fixup' call that we can use instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116852/new/

https://reviews.llvm.org/D116852



More information about the llvm-commits mailing list