[PATCH] D116781: [DebugInfo] Move the SymbolizableObjectFile header to include/llvm.

Fri Jan 7 16:45:12 PST 2022

dblaikie added a comment.

In D116781#3228744 <https://reviews.llvm.org/D116781#3228744>, @MaskRay wrote:

> @dblaikie
>
> Moving classes from .cpp to .h usually requires some mechanism to prevent folks (who are making refactorings) from undoing the change.
> This can sometimes by done by having a unit test.

If the new use is going to be out-of-tree, that's generally a good idea - but in this case the new use is in-tree in subsequent patches in this patch series I think, so I think it's OK as-is? (once the rest of the patch series is in, it'll be clear that folding this back into the .cpp won't be feasible since there'll be multiple callers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116781/new/

https://reviews.llvm.org/D116781