[PATCH] D115847: [mlgo][inline] Improve global state tracking

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/test/Transforms/Inline/ML/state-tracking-coro.ll:1
+; Based on llvm/test/Transforms/Coroutines/coro-split-02.ll
+; Corosplit will keep f1 and add 3 more functions.
----------------
aeubanks wrote:
> I'm not sure I'd want to depend on exact coroutine semantics for these tests especially since it seems like they keep changing
> but if we don't do that then I don't think there's any other way to test new functions being added to the call graph
> maybe it's ok if these tests aren't run normally and you're fine with keeping these up to date if coroutine semantics/pipelines change
ack - this is just taking a dep on the coro pass generating a few fcts, I'm hoping that won't change, but if it does and it becomes burdensome, we can cross that bridge then, I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115847/new/

https://reviews.llvm.org/D115847