[PATCH] D116780: [memprof] Move the meminfo block struct to MemProfData.inc.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added inline comments.


================
Comment at: compiler-rt/lib/memprof/tests/rawprofile.cpp:136
+      0x10, 0, 0, 0, 0, 0, 0, 0, // Offset
+      0x0,                       // Uuid (not yet recorded).
   };
----------------
davidxl wrote:
> More explanation on this change?
Duplicated the comment I had in the .inc file. It's useful to record the linker build id (i.e. the uuid field here: https://git.io/J9O47) however, this is not implemented in sanitizer_procmaps_linux yet. Our initial approach was to do symbolization using internal tooling and this was necessary. However, now we are going to symbolize using llvm-profdata and this is not strictly necessary anymore. It is still good to have for sanity checks as well as other visualization and analysis tools that we may build in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116780/new/

https://reviews.llvm.org/D116780