[PATCH] D116524: [cmake] Add read-me for the common CMake utils
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 7 12:45:59 PST 2022
phosek reopened this revision.
phosek added a comment.
This revision is now accepted and ready to land.
This looks reasonable, thank you for writing it. The only thing I'm not sure about is the format. We use reStructuredText for most documentation in LLVM although we do have a handful of Markdown documents in the tree. Personally, I'm fine with either format but others may have stronger opinion on this.
================
Comment at: cmake/README.md:44
+
+If runtime libs, we skip the `if(NOT DEFINED` part:
+
----------------
I'd say "For runtime libraries" instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116524/new/
https://reviews.llvm.org/D116524
More information about the llvm-commits
mailing list