[PATCH] D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now).

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 12:28:55 PST 2022


MaskRay added a comment.

In D116787#3228312 <https://reviews.llvm.org/D116787#3228312>, @oontvoo wrote:

> In D116787#3228302 <https://reviews.llvm.org/D116787#3228302>, @MaskRay wrote:
>
>> local/external/undefined may be better as it is more likely the order matches ld64.lld order.
>
> How strongly do you feel about this? I find it simpler to just sort by the numerical value of the `n_type` field

Not strong. Happy to defer to #lld-macho <https://reviews.llvm.org/tag/lld-macho/> folks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116787/new/

https://reviews.llvm.org/D116787



More information about the llvm-commits mailing list