[PATCH] D116819: [AMDGPU] Disable optimizeEndCf at -O0

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 11:58:16 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp:814
+  EnableOptimizeEndCf =
+      RemoveRedundantEndcf && MF.getTarget().getOptLevel() > CodeGenOpt::None;
 
----------------
rampitec wrote:
> arsenm wrote:
> > rampitec wrote:
> > > There is skipFunction() method, it will check optnone attribute. Just checking -O0 does not check this.
> > skipFunction wouldn't be appropriate because this is still a lowering pass we must run
> It still can be checked to skip optimization part of it only. Isn't it?
You can also just directly check optnone


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116819/new/

https://reviews.llvm.org/D116819



More information about the llvm-commits mailing list