[PATCH] D108850: [LLD] Remove global state in lldCommon

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo accepted this revision.
oontvoo added a comment.

perf-impact seems minimal to me. LGTM!

  x base.txt
  + with_patch.txt
  
  SYSTEM CPU time: 
      N           Min           Max        Median           Avg        Stddev
  x  10          0.99          1.01          1.01         1.003   0.008232726
  +  10          0.98          1.04          1.02         1.014   0.022705848
  No difference proven at 95.0% confidence
  
  USER CPU time: 
      N           Min           Max        Median           Avg        Stddev
  x  10          3.56          3.61          3.57         3.575   0.018408935
  +  10          3.56          3.71          3.62         3.625   0.053176854
  Difference at 95.0% confidence
  	0.05 +/- 0.0373876
  	1.3986% +/- 1.04581%
  	(Student's t, pooled s = 0.0397911)
  
  WALL time: 
      N           Min           Max        Median           Avg        Stddev
  x  10          4.06          4.12          4.08         4.085   0.024152295
  +  10          4.04          4.23          4.14          4.14   0.070867639
  Difference at 95.0% confidence
  	0.055 +/- 0.0497434
  	1.34639% +/- 1.21771%
  	(Student's t, pooled s = 0.0529413)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108850/new/

https://reviews.llvm.org/D108850