[PATCH] D116816: [instcombine] Delete duplicate object size logic
Dávid Bolvanský via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 7 09:02:23 PST 2022
xbolva00 added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2578
+ if (getObjectSize(&Call, Size, DL, TLI, Opts) && Size > 0) {
+ // TODO: should be annotating these nonnull
if (isOpNewLikeFn(&Call, TLI))
----------------
reames wrote:
> xbolva00 wrote:
> > all allocation fns have nonnull attribute, I believe.
> Er, definitely not. Malloc can return nullptr on error. Did you maybe mean that all operator new versions did? I couldn't find that code, can you point me to it?
Yeah right, just for new calls.
Yes, todo is correct here for others
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116816/new/
https://reviews.llvm.org/D116816
More information about the llvm-commits
mailing list