[PATCH] D116730: [AArch64][SVE] Remove Redundant aarch64.sve.convert.to.svbool

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 08:11:17 PST 2022


DavidTruby added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:406
+
+  IRBuilder<> Builder(II.getContext());
+  Builder.SetInsertPoint(&II);
----------------
MattDevereau wrote:
> DavidTruby wrote:
> > nit: you don't need the `<>` here it can just be `IRBuilder`
> i'm compiling this locally with clang++11 with default flags, it errors when this is removed
Interesting! clang 13 and gcc also fail to compile without them, but it works with C++17 instead of 14. I wonder why the empty brackets are necessary here... Anyway they do seem to be so ignore my comment :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116730/new/

https://reviews.llvm.org/D116730



More information about the llvm-commits mailing list