[PATCH] D116807: [GlobalISel] Remove TargetLowering::isConstantUnsignedBitfieldExtractLegal

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 08:05:34 PST 2022


foad added a comment.

In D116807#3227570 <https://reviews.llvm.org/D116807#3227570>, @arsenm wrote:

> Legality rules can't be context dependent on the specific operands used, but IIRC here it only wants to use it if the operands are constants

Well in practice the implementations of isConstantUnsignedBitfieldExtractLegal did exactly the same as the legal-or-custom check anyway, so it still seems redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116807/new/

https://reviews.llvm.org/D116807



More information about the llvm-commits mailing list