[PATCH] D116807: [GlobalISel] Remove TargetLowering::isConstantUnsignedBitfieldExtractLegal

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 06:31:42 PST 2022


foad added a comment.

TBH I don't understand why D99283 <https://reviews.llvm.org/D99283> introduced this target lowering hook in the first place. Comments on the review say "The annoying part (for AArch64) is that the legality checks don't work with custom legalization". Did isLegalOrCustom not exist back then? Or does it not do the right thing? (I don't see any tests failing with this patch.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116807/new/

https://reviews.llvm.org/D116807



More information about the llvm-commits mailing list