[PATCH] D116805: ARM: make FastISel & GISel pass -1 to ADJCALLSTACKUP to signal no callee pop.

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 05:52:28 PST 2022


t.p.northover created this revision.
Herald added subscribers: hiraditya, kristof.beyls, mcrosier.
t.p.northover requested review of this revision.
Herald added a project: LLVM.

The interface for these instructions changed with support for mandatory tail calls, and now -1 indicates the `CalleePopAmount` argument is not valid. Unfortunately I didn't realise FastISel or GISel did calls at the time so didn't update them.

Should fix https://github.com/llvm/llvm-project/issues/52723.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116805

Files:
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/ARM/ARMFastISel.cpp
  llvm/test/CodeGen/ARM/GlobalISel/arm-call-lowering.ll
  llvm/test/CodeGen/ARM/GlobalISel/arm-param-lowering.ll
  llvm/test/CodeGen/ARM/GlobalISel/irtranslator-varargs-lowering.ll
  llvm/test/CodeGen/ARM/fast-call-frame-restore.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116805.398116.patch
Type: text/x-patch
Size: 16750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220107/91431c71/attachment.bin>


More information about the llvm-commits mailing list