[PATCH] D116802: [GlobalISel] Fix legality checks for G_UBFX combines

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 04:11:54 PST 2022


foad added a comment.

Further cleanups are possible:

1. Change CombinerHelper::matchBitfieldExtractFromShrAnd to use getPreferredShiftAmountTy for the shift-amount-like operands of G_UBFX, like all the other G_*BFX combines do. Change AArch64's G_*BFX legality rules to match.
2. Remove isConstantUnsignedBitfieldExtractLegal since it doesn't seem to do any more than a standard legality check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116802/new/

https://reviews.llvm.org/D116802



More information about the llvm-commits mailing list