[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 01:35:51 PST 2022


pengfei added a comment.

In D115942#3226101 <https://reviews.llvm.org/D115942#3226101>, @craig.topper wrote:

> Does this have the same autoupgrade issues as @efriedma raised in https://reviews.llvm.org/D86310

No. The differences are that i128 can be generated by front end while f80 cannot without D115441 <https://reviews.llvm.org/D115441> in the given datalayout (i.e., MSVC).
I also did some experiments, e.g., generating a bc file (without f80 type) with existing compiler and compile it with the one with this patch. There's no error during compilation. So I think we don't bother to do autoupgrade at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115942/new/

https://reviews.llvm.org/D115942



More information about the llvm-commits mailing list