[PATCH] D115724: [InstCombine] Fold for masked scatters to a uniform address

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 01:24:11 PST 2022


CarolineConcatto added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/masked_intrinsics.ll:292
+
+define void @scatter_nxv4i16_uniform_vals_uniform_ptrs_all_active_mask(i16* %dst, i16 %val) {
+; CHECK-LABEL: @scatter_nxv4i16_uniform_vals_uniform_ptrs_all_active_mask(
----------------
sdesmalen wrote:
> this test seems is redundant, because it's covered by the test above.
Yes, it is, but this one is with vscale. It is the same on gather.
This is a positive test, and not negative!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115724/new/

https://reviews.llvm.org/D115724



More information about the llvm-commits mailing list