[llvm] 6a563e2 - [NFC][SCEV][IndVars] Add more tests for exit count w/ `select`
Roman Lebedev via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 6 14:30:38 PST 2022
Author: Roman Lebedev
Date: 2022-01-07T01:30:21+03:00
New Revision: 6a563e2570684d2398a7b800ed1165fcfe06e829
URL: https://github.com/llvm/llvm-project/commit/6a563e2570684d2398a7b800ed1165fcfe06e829
DIFF: https://github.com/llvm/llvm-project/commit/6a563e2570684d2398a7b800ed1165fcfe06e829.diff
LOG: [NFC][SCEV][IndVars] Add more tests for exit count w/ `select`
See https://github.com/llvm/llvm-project/issues/53020
Added:
llvm/test/Analysis/ScalarEvolution/exit-count-select-safe.ll
llvm/test/Transforms/IndVarSimplify/exit-count-select.ll
Modified:
llvm/test/Analysis/ScalarEvolution/exit-count-select.ll
Removed:
################################################################################
diff --git a/llvm/test/Analysis/ScalarEvolution/exit-count-select-safe.ll b/llvm/test/Analysis/ScalarEvolution/exit-count-select-safe.ll
new file mode 100644
index 0000000000000..90a9bbfec4146
--- /dev/null
+++ b/llvm/test/Analysis/ScalarEvolution/exit-count-select-safe.ll
@@ -0,0 +1,122 @@
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
+; RUN: opt -disable-output "-passes=print<scalar-evolution>" %s 2>&1 | FileCheck %s
+
+; exact-not-taken cannot be umin(n, m) because it is possible for (n, m) to be (0, poison)
+; https://alive2.llvm.org/ce/z/NsP9ue
+define i32 @logical_and_2ops(i32 %n, i32 %m) {
+; CHECK-LABEL: 'logical_and_2ops'
+; CHECK-NEXT: Classifying expressions for: @logical_and_2ops
+; CHECK-NEXT: %i = phi i32 [ 0, %entry ], [ %i.next, %loop ]
+; CHECK-NEXT: --> {0,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %i.next = add i32 %i, 1
+; CHECK-NEXT: --> {1,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %cond = select i1 %cond_p0, i1 %cond_p1, i1 false
+; CHECK-NEXT: --> %cond U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
+; CHECK-NEXT: Determining loop execution counts for: @logical_and_2ops
+; CHECK-NEXT: Loop %loop: Unpredictable backedge-taken count.
+; CHECK-NEXT: Loop %loop: max backedge-taken count is -1
+; CHECK-NEXT: Loop %loop: Unpredictable predicated backedge-taken count.
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp ult i32 %i, %n
+ %cond_p1 = icmp ult i32 %i, %m
+ %cond = select i1 %cond_p0, i1 %cond_p1, i1 false
+ br i1 %cond, label %loop, label %exit
+exit:
+ ret i32 %i
+}
+
+; exact-not-taken cannot be umin(n, m) because it is possible for (n, m) to be (0, poison)
+; https://alive2.llvm.org/ce/z/ApRitq
+define i32 @logical_or_2ops(i32 %n, i32 %m) {
+; CHECK-LABEL: 'logical_or_2ops'
+; CHECK-NEXT: Classifying expressions for: @logical_or_2ops
+; CHECK-NEXT: %i = phi i32 [ 0, %entry ], [ %i.next, %loop ]
+; CHECK-NEXT: --> {0,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %i.next = add i32 %i, 1
+; CHECK-NEXT: --> {1,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %cond = select i1 %cond_p0, i1 true, i1 %cond_p1
+; CHECK-NEXT: --> %cond U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
+; CHECK-NEXT: Determining loop execution counts for: @logical_or_2ops
+; CHECK-NEXT: Loop %loop: Unpredictable backedge-taken count.
+; CHECK-NEXT: Loop %loop: max backedge-taken count is -1
+; CHECK-NEXT: Loop %loop: Unpredictable predicated backedge-taken count.
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp uge i32 %i, %n
+ %cond_p1 = icmp uge i32 %i, %m
+ %cond = select i1 %cond_p0, i1 true, i1 %cond_p1
+ br i1 %cond, label %exit, label %loop
+exit:
+ ret i32 %i
+}
+
+define i32 @logical_and_3ops(i32 %n, i32 %m, i32 %k) {
+; CHECK-LABEL: 'logical_and_3ops'
+; CHECK-NEXT: Classifying expressions for: @logical_and_3ops
+; CHECK-NEXT: %i = phi i32 [ 0, %entry ], [ %i.next, %loop ]
+; CHECK-NEXT: --> {0,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %i.next = add i32 %i, 1
+; CHECK-NEXT: --> {1,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %cond_p3 = select i1 %cond_p0, i1 %cond_p1, i1 false
+; CHECK-NEXT: --> %cond_p3 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
+; CHECK-NEXT: %cond = select i1 %cond_p3, i1 %cond_p2, i1 false
+; CHECK-NEXT: --> %cond U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
+; CHECK-NEXT: Determining loop execution counts for: @logical_and_3ops
+; CHECK-NEXT: Loop %loop: Unpredictable backedge-taken count.
+; CHECK-NEXT: Loop %loop: max backedge-taken count is -1
+; CHECK-NEXT: Loop %loop: Unpredictable predicated backedge-taken count.
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp ult i32 %i, %n
+ %cond_p1 = icmp ult i32 %i, %m
+ %cond_p2 = icmp ult i32 %i, %k
+ %cond_p3 = select i1 %cond_p0, i1 %cond_p1, i1 false
+ %cond = select i1 %cond_p3, i1 %cond_p2, i1 false
+ br i1 %cond, label %loop, label %exit
+exit:
+ ret i32 %i
+}
+
+define i32 @logical_or_3ops(i32 %n, i32 %m, i32 %k) {
+; CHECK-LABEL: 'logical_or_3ops'
+; CHECK-NEXT: Classifying expressions for: @logical_or_3ops
+; CHECK-NEXT: %i = phi i32 [ 0, %entry ], [ %i.next, %loop ]
+; CHECK-NEXT: --> {0,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %i.next = add i32 %i, 1
+; CHECK-NEXT: --> {1,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
+; CHECK-NEXT: %cond_p3 = select i1 %cond_p0, i1 true, i1 %cond_p1
+; CHECK-NEXT: --> %cond_p3 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
+; CHECK-NEXT: %cond = select i1 %cond_p3, i1 true, i1 %cond_p2
+; CHECK-NEXT: --> %cond U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
+; CHECK-NEXT: Determining loop execution counts for: @logical_or_3ops
+; CHECK-NEXT: Loop %loop: Unpredictable backedge-taken count.
+; CHECK-NEXT: Loop %loop: max backedge-taken count is -1
+; CHECK-NEXT: Loop %loop: Unpredictable predicated backedge-taken count.
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp uge i32 %i, %n
+ %cond_p1 = icmp uge i32 %i, %m
+ %cond_p2 = icmp uge i32 %i, %k
+ %cond_p3 = select i1 %cond_p0, i1 true, i1 %cond_p1
+ %cond = select i1 %cond_p3, i1 true, i1 %cond_p2
+ br i1 %cond, label %exit, label %loop
+exit:
+ ret i32 %i
+}
diff --git a/llvm/test/Analysis/ScalarEvolution/exit-count-select.ll b/llvm/test/Analysis/ScalarEvolution/exit-count-select.ll
index 08a3d53c0a4e9..e20bc21d7f672 100644
--- a/llvm/test/Analysis/ScalarEvolution/exit-count-select.ll
+++ b/llvm/test/Analysis/ScalarEvolution/exit-count-select.ll
@@ -1,36 +1,6 @@
; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
; RUN: opt -disable-output "-passes=print<scalar-evolution>" %s 2>&1 | FileCheck %s
-
-; exact-not-taken cannot be umin(n, m) because it is possible for (n, m) to be (0, poison)
-; https://alive2.llvm.org/ce/z/NsP9ue
-define void @logical_and(i32 %n, i32 %m) {
-; CHECK-LABEL: 'logical_and'
-; CHECK-NEXT: Classifying expressions for: @logical_and
-; CHECK-NEXT: %i = phi i32 [ 0, %entry ], [ %i.next, %loop ]
-; CHECK-NEXT: --> {0,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
-; CHECK-NEXT: %i.next = add i32 %i, 1
-; CHECK-NEXT: --> {1,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
-; CHECK-NEXT: %cond = select i1 %cond_i, i1 %cond_i2, i1 false
-; CHECK-NEXT: --> %cond U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
-; CHECK-NEXT: Determining loop execution counts for: @logical_and
-; CHECK-NEXT: Loop %loop: Unpredictable backedge-taken count.
-; CHECK-NEXT: Loop %loop: max backedge-taken count is -1
-; CHECK-NEXT: Loop %loop: Unpredictable predicated backedge-taken count.
-;
-entry:
- br label %loop
-loop:
- %i = phi i32 [0, %entry], [%i.next, %loop]
- %i.next = add i32 %i, 1
- %cond_i = icmp ult i32 %i, %n
- %cond_i2 = icmp ult i32 %i, %m
- %cond = select i1 %cond_i, i1 %cond_i2, i1 false
- br i1 %cond, label %loop, label %exit
-exit:
- ret void
-}
-
; If m is constant, exact-not-taken is umin(n, m)
; https://alive2.llvm.org/ce/z/ZTNXgY
define void @logical_and_m_const(i32 %n) {
@@ -156,35 +126,6 @@ exit:
ret void
}
-; exact-not-taken cannot be umin(n, m) because it is possible for (n, m) to be (0, poison)
-; https://alive2.llvm.org/ce/z/ApRitq
-define void @logical_or(i32 %n, i32 %m) {
-; CHECK-LABEL: 'logical_or'
-; CHECK-NEXT: Classifying expressions for: @logical_or
-; CHECK-NEXT: %i = phi i32 [ 0, %entry ], [ %i.next, %loop ]
-; CHECK-NEXT: --> {0,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
-; CHECK-NEXT: %i.next = add i32 %i, 1
-; CHECK-NEXT: --> {1,+,1}<%loop> U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Computable }
-; CHECK-NEXT: %cond = select i1 %cond_i, i1 true, i1 %cond_i2
-; CHECK-NEXT: --> %cond U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %loop: Variant }
-; CHECK-NEXT: Determining loop execution counts for: @logical_or
-; CHECK-NEXT: Loop %loop: Unpredictable backedge-taken count.
-; CHECK-NEXT: Loop %loop: max backedge-taken count is -1
-; CHECK-NEXT: Loop %loop: Unpredictable predicated backedge-taken count.
-;
-entry:
- br label %loop
-loop:
- %i = phi i32 [0, %entry], [%i.next, %loop]
- %i.next = add i32 %i, 1
- %cond_i = icmp uge i32 %i, %n
- %cond_i2 = icmp uge i32 %i, %m
- %cond = select i1 %cond_i, i1 true, i1 %cond_i2
- br i1 %cond, label %exit, label %loop
-exit:
- ret void
-}
-
; If m is constant, exact-not-taken is umin(n, m)
; https://alive2.llvm.org/ce/z/RQmJiq
define void @logical_or_m_const(i32 %n) {
diff --git a/llvm/test/Transforms/IndVarSimplify/exit-count-select.ll b/llvm/test/Transforms/IndVarSimplify/exit-count-select.ll
new file mode 100644
index 0000000000000..3bc6150024df1
--- /dev/null
+++ b/llvm/test/Transforms/IndVarSimplify/exit-count-select.ll
@@ -0,0 +1,122 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -indvars -S | FileCheck %s
+
+define i32 @logical_and_2ops(i32 %n, i32 %m) {
+; CHECK-LABEL: @logical_and_2ops(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br label [[LOOP:%.*]]
+; CHECK: loop:
+; CHECK-NEXT: [[I:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[I_NEXT:%.*]], [[LOOP]] ]
+; CHECK-NEXT: [[I_NEXT]] = add i32 [[I]], 1
+; CHECK-NEXT: [[COND_P0:%.*]] = icmp ult i32 [[I]], [[N:%.*]]
+; CHECK-NEXT: [[COND_P1:%.*]] = icmp ult i32 [[I]], [[M:%.*]]
+; CHECK-NEXT: [[COND:%.*]] = select i1 [[COND_P0]], i1 [[COND_P1]], i1 false
+; CHECK-NEXT: br i1 [[COND]], label [[LOOP]], label [[EXIT:%.*]]
+; CHECK: exit:
+; CHECK-NEXT: [[I_LCSSA:%.*]] = phi i32 [ [[I]], [[LOOP]] ]
+; CHECK-NEXT: ret i32 [[I_LCSSA]]
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp ult i32 %i, %n
+ %cond_p1 = icmp ult i32 %i, %m
+ %cond = select i1 %cond_p0, i1 %cond_p1, i1 false
+ br i1 %cond, label %loop, label %exit
+exit:
+ ret i32 %i
+}
+
+define i32 @logical_or_2ops(i32 %n, i32 %m) {
+; CHECK-LABEL: @logical_or_2ops(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br label [[LOOP:%.*]]
+; CHECK: loop:
+; CHECK-NEXT: [[I:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[I_NEXT:%.*]], [[LOOP]] ]
+; CHECK-NEXT: [[I_NEXT]] = add i32 [[I]], 1
+; CHECK-NEXT: [[COND_P0:%.*]] = icmp uge i32 [[I]], [[N:%.*]]
+; CHECK-NEXT: [[COND_P1:%.*]] = icmp uge i32 [[I]], [[M:%.*]]
+; CHECK-NEXT: [[COND:%.*]] = select i1 [[COND_P0]], i1 true, i1 [[COND_P1]]
+; CHECK-NEXT: br i1 [[COND]], label [[EXIT:%.*]], label [[LOOP]]
+; CHECK: exit:
+; CHECK-NEXT: [[I_LCSSA:%.*]] = phi i32 [ [[I]], [[LOOP]] ]
+; CHECK-NEXT: ret i32 [[I_LCSSA]]
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp uge i32 %i, %n
+ %cond_p1 = icmp uge i32 %i, %m
+ %cond = select i1 %cond_p0, i1 true, i1 %cond_p1
+ br i1 %cond, label %exit, label %loop
+exit:
+ ret i32 %i
+}
+
+define i32 @logical_and_3ops(i32 %n, i32 %m, i32 %k) {
+; CHECK-LABEL: @logical_and_3ops(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br label [[LOOP:%.*]]
+; CHECK: loop:
+; CHECK-NEXT: [[I:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[I_NEXT:%.*]], [[LOOP]] ]
+; CHECK-NEXT: [[I_NEXT]] = add i32 [[I]], 1
+; CHECK-NEXT: [[COND_P0:%.*]] = icmp ult i32 [[I]], [[N:%.*]]
+; CHECK-NEXT: [[COND_P1:%.*]] = icmp ult i32 [[I]], [[M:%.*]]
+; CHECK-NEXT: [[COND_P2:%.*]] = icmp ult i32 [[I]], [[K:%.*]]
+; CHECK-NEXT: [[COND_P3:%.*]] = select i1 [[COND_P0]], i1 [[COND_P1]], i1 false
+; CHECK-NEXT: [[COND:%.*]] = select i1 [[COND_P3]], i1 [[COND_P2]], i1 false
+; CHECK-NEXT: br i1 [[COND]], label [[LOOP]], label [[EXIT:%.*]]
+; CHECK: exit:
+; CHECK-NEXT: [[I_LCSSA:%.*]] = phi i32 [ [[I]], [[LOOP]] ]
+; CHECK-NEXT: ret i32 [[I_LCSSA]]
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp ult i32 %i, %n
+ %cond_p1 = icmp ult i32 %i, %m
+ %cond_p2 = icmp ult i32 %i, %k
+ %cond_p3 = select i1 %cond_p0, i1 %cond_p1, i1 false
+ %cond = select i1 %cond_p3, i1 %cond_p2, i1 false
+ br i1 %cond, label %loop, label %exit
+exit:
+ ret i32 %i
+}
+
+define i32 @logical_or_3ops(i32 %n, i32 %m, i32 %k) {
+; CHECK-LABEL: @logical_or_3ops(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br label [[LOOP:%.*]]
+; CHECK: loop:
+; CHECK-NEXT: [[I:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[I_NEXT:%.*]], [[LOOP]] ]
+; CHECK-NEXT: [[I_NEXT]] = add i32 [[I]], 1
+; CHECK-NEXT: [[COND_P0:%.*]] = icmp uge i32 [[I]], [[N:%.*]]
+; CHECK-NEXT: [[COND_P1:%.*]] = icmp uge i32 [[I]], [[M:%.*]]
+; CHECK-NEXT: [[COND_P2:%.*]] = icmp uge i32 [[I]], [[K:%.*]]
+; CHECK-NEXT: [[COND_P3:%.*]] = select i1 [[COND_P0]], i1 true, i1 [[COND_P1]]
+; CHECK-NEXT: [[COND:%.*]] = select i1 [[COND_P3]], i1 true, i1 [[COND_P2]]
+; CHECK-NEXT: br i1 [[COND]], label [[EXIT:%.*]], label [[LOOP]]
+; CHECK: exit:
+; CHECK-NEXT: [[I_LCSSA:%.*]] = phi i32 [ [[I]], [[LOOP]] ]
+; CHECK-NEXT: ret i32 [[I_LCSSA]]
+;
+entry:
+ br label %loop
+loop:
+ %i = phi i32 [0, %entry], [%i.next, %loop]
+ %i.next = add i32 %i, 1
+ %cond_p0 = icmp uge i32 %i, %n
+ %cond_p1 = icmp uge i32 %i, %m
+ %cond_p2 = icmp uge i32 %i, %k
+ %cond_p3 = select i1 %cond_p0, i1 true, i1 %cond_p1
+ %cond = select i1 %cond_p3, i1 true, i1 %cond_p2
+ br i1 %cond, label %exit, label %loop
+exit:
+ ret i32 %i
+}
More information about the llvm-commits
mailing list