[PATCH] D115852: Passthrough LLVM_USE_LLD LLVM_USE_LINKER into runtimes

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 13:40:04 PST 2022


smeenai added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:341
                                       -DLLVM_DEFAULT_TARGET_TRIPLE=${target}
                                       -DLLVM_ENABLE_PROJECTS_USED=${LLVM_ENABLE_PROJECTS_USED}
                                       -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON
----------------
Would it work to add `-DLLVM_USE_LINKER=${LLVM_USE_LINKER}` instead of PASSTHROUGH_PREFIXES? That'd still be incorrect for cross-compilation by default, but then we could at least override it by using the target-specific runtime arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115852/new/

https://reviews.llvm.org/D115852



More information about the llvm-commits mailing list