[PATCH] D113084: [flang] Add a semantics test for co_broadcast

Katherine Rasmussen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 11:05:20 PST 2022


ktras requested changes to this revision.
ktras added a comment.
This revision now requires changes to proceed.

Similarly to comments I made in my review for D116133 <https://reviews.llvm.org/D116133>,  the `co_broadcast` call could be improved by adding a call which contains optional arguments, but not required arguments. Also, there could be checks added to try and violate the `intent-spec` of `stat` and `errmsg`. There are also some non-standard single quote characters in the expected error messages that should be replaced.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113084/new/

https://reviews.llvm.org/D113084



More information about the llvm-commits mailing list