[llvm] 5e7912d - [LowerMatrixIntrinsics] writeFnName - don't dereference a dyn_cast<>. NFC.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 09:09:54 PST 2022


Author: Simon Pilgrim
Date: 2022-01-06T17:09:32Z
New Revision: 5e7912d80fca1f20ee00fadc6c6ec8ac87ccd023

URL: https://github.com/llvm/llvm-project/commit/5e7912d80fca1f20ee00fadc6c6ec8ac87ccd023
DIFF: https://github.com/llvm/llvm-project/commit/5e7912d80fca1f20ee00fadc6c6ec8ac87ccd023.diff

LOG: [LowerMatrixIntrinsics] writeFnName - don't dereference a dyn_cast<>. NFC.

dyn_cast<> can return null - use cast<> instead to assert the cast is valid before dereferencing the casted pointer.

Fixes static-analyzer null dereference warning.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
index 4e4097e13271..3777a849f4c3 100644
--- a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
+++ b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
@@ -1895,7 +1895,7 @@ class LowerMatrixIntrinsics {
           write(Name);
           return;
         }
-        IntrinsicInst *II = dyn_cast<IntrinsicInst>(CI);
+        auto *II = cast<IntrinsicInst>(CI);
         write(Intrinsic::getBaseName(II->getIntrinsicID())
                   .drop_front(StringRef("llvm.matrix.").size()));
         write(".");


        


More information about the llvm-commits mailing list