[PATCH] D116551: [AVR] Mark call-clobbered registers as clobbered in interrupt handlers

Thu Jan 6 08:28:50 PST 2022

aykevl added a comment.

In D116551#3221666 <https://reviews.llvm.org/D116551#3221666>, @benshi001 wrote:

> Just one suggestion, run `llvm/utils/update_llc_test_checks.py` against the test `case llvm/test/CodeGen/AVR/interrupts.ll`

I think it is better to not do this for this test. With `update_llc_test_checks.py`, all the register names would be hidden. But the register names (`r0`, `r1`, etc) are an important part of this test.

================
Comment at: llvm/test/CodeGen/AVR/interrupts.ll:1
 ; RUN: llc < %s -march=avr | FileCheck %s

----------------
benshi001 wrote:
> Would it be better to add an option `-verify-machineinstrs` ?
Not sure. I've looked at other targets and most have it only on a small subset of tests.
If you want to enable the machine verifier, you can build LLVM with `-DLLVM_ENABLE_EXPENSIVE_CHECKS=True` or you can run `llvm-lit` manually, in my case:

    ../llvm-build.main/bin/llvm-lit -Dllc="llc -verify-machineinstrs" -sv llvm/test/CodeGen/AVR/

I usually use the above command to check for verification issues. This is how I found many issues that I fixed over several patches (see D107853#3224989).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116551/new/

https://reviews.llvm.org/D116551