[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake Egan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 06:43:34 PST 2022


Jake-Egan added inline comments.


================
Comment at: clang/test/ASTMerge/codegen-body/test.c:1
+// UNSUPPORTED: powerpc64-ibm-aix
 // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c
----------------
Jake-Egan wrote:
> shchenz wrote:
> > Jake-Egan wrote:
> > > shchenz wrote:
> > > > Do we still need this? -emit-obj is already excluded?
> > > Excluding this test causes regressions because LIT can't find any tests at `/codegen-body` directory:
> > > ```
> > > Clang :: utils/update_cc_test_checks/global-hex-value-regex.test
> > > Clang :: utils/update_cc_test_checks/global-value-regex.test
> > > ```
> > > I figure it's easier to mark this test unsupported. 
> > Is it possible to add `expected-no-diagnostics` for any of the above two RUN lines? So we will have a test point and be able to exclude this case?
> Unfortunately adding `expected-no-diagnostics` fix the issue. The existing `expected-no-diagnostics` is already applied to all the RUN lines.
> fix the issue
I meant *doesn't* fix the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113049/new/

https://reviews.llvm.org/D113049



More information about the llvm-commits mailing list