[PATCH] D116728: [LICM] Check for noalias call instead of alloc like fn

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 03:23:01 PST 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

It seems at least DSE's `isInvisibleToCallerAfterRet` and `isInvisibleToCallerBeforeRet` could also use `isNoAliasCall` instead of `isAllocLikeFn`



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1939
   //   1) Object can't be escaped by this function.  This is what
   //      PointerMayBeCaptured checks.
   //   2) Object can't have been captured at definition site.  For this, we
----------------
While you are here, maybe also update this comment here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116728/new/

https://reviews.llvm.org/D116728



More information about the llvm-commits mailing list