[PATCH] D115724: [InstCombine] Fold for masked scatters to a uniform address

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/masked_intrinsics.ll:274
+
+; The scatters in the tests below take a splatted pointer
+
----------------
nit: ; Test scatters that can be simplified to scalar stores.


================
Comment at: llvm/test/Transforms/InstCombine/masked_intrinsics.ll:292
+
+define void @scatter_nxv4i16_uniform_vals_uniform_ptrs_all_active_mask(i16* %dst, i16 %val) {
+; CHECK-LABEL: @scatter_nxv4i16_uniform_vals_uniform_ptrs_all_active_mask(
----------------
this test seems is redundant, because it's covered by the test above.


================
Comment at: llvm/test/Transforms/InstCombine/masked_intrinsics.ll:307
+
+
+
----------------
nit: remove one of the newlines here


================
Comment at: llvm/test/Transforms/InstCombine/masked_intrinsics.ll:346
+
+;; Pointer is splat, but mask is not all active and  value is not a splat
+define void @scatter_v4i16_no_uniform_vals_uniform_ptrs_all_inactive_mask(i16* %dst, <4 x i16>* %src) {
----------------
nit: can you add a comment here that these are negative tests?
(and change the name of the functions to `@negative_scatter_...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115724/new/

https://reviews.llvm.org/D115724