[PATCH] D116690: [SLP]Initialize the lane with the given value instead of default 0.

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 20:37:13 PST 2022


vporpo added a comment.

Do you think the regressions will go away with one of your follow-up patches?



================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/transpose-inseltpoison.ll:74
 ; CHECK-NEXT:    [[TMP5:%.*]] = add <4 x i32> [[TMP4]], [[TMP3]]
-; CHECK-NEXT:    ret <4 x i32> [[TMP5]]
+; CHECK-NEXT:    [[TMP6:%.*]] = shufflevector <4 x i32> [[TMP5]], <4 x i32> poison, <4 x i32> <i32 1, i32 0, i32 2, i32 3>
+; CHECK-NEXT:    ret <4 x i32> [[TMP6]]
----------------
regression?


================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/transpose.ll:74
 ; CHECK-NEXT:    [[TMP5:%.*]] = add <4 x i32> [[TMP4]], [[TMP3]]
-; CHECK-NEXT:    ret <4 x i32> [[TMP5]]
+; CHECK-NEXT:    [[TMP6:%.*]] = shufflevector <4 x i32> [[TMP5]], <4 x i32> poison, <4 x i32> <i32 1, i32 0, i32 2, i32 3>
+; CHECK-NEXT:    ret <4 x i32> [[TMP6]]
----------------
regression?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116690/new/

https://reviews.llvm.org/D116690



More information about the llvm-commits mailing list