[PATCH] D116719: [NFC][RISCV] Make the macro names more uniform

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.cpp:27
 
-#define DEBUG_TYPE "asm-printer"
+#define DEBUG_TYPE "riscv-inst-printer"
 
----------------
Revert this. Most targets uses "asm-printer". This is common functionality on all targets, there doesn't need to be a different way to spell it for RISCV.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCCodeEmitter.cpp:33
 
-#define DEBUG_TYPE "mccodeemitter"
+#define DEBUG_TYPE "riscv-mc-code-emitter"
 
----------------
Same, "mccodeemitter" is used by the majority of targets.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:34
 
-#define DEBUG_TYPE "asm-printer"
+#define DEBUG_TYPE "riscv-asm-printer"
 
----------------
This seems to have more inconsistency between targets, but every target has this file so I don't see why we need a different string for RISCV.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116719/new/

https://reviews.llvm.org/D116719