[PATCH] D116705: [lld-macho] Increase slops to prevent thunk out of range

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 18:01:13 PST 2022


smeenai added inline comments.


================
Comment at: lld/MachO/ConcatOutputSection.cpp:247
     // grows. So leave room for a bunch of thunks.
-    unsigned slop = 100 * thunkSize;
+    unsigned slop = 200 * thunkSize;
     while (finalIdx < endIdx && isecAddr + inputs[finalIdx]->getSize() <
----------------
oontvoo wrote:
> Where is this number from?
> (would have asked the same question for '100').
> 
> Is this just kicking the can down the road?
Also can we make it a power of two? :p


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116705/new/

https://reviews.llvm.org/D116705



More information about the llvm-commits mailing list