[PATCH] D106995: [IROutliner] Allowing PHINodes in Exit Blocks

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1343
+  // Find if a PHIBlock exists for this return value already.  If it is
+  // the first time we are anaylzing this, we will not, so we record it.
+  PhiBlockForRetVal = Group.PHIBlocks.find(RetVal);
----------------



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1492
+    findCanonNumsForPHI(&CurrPN, *FirstRegion, OutputMappings, CurrentCanonNums,
+                        true);
+
----------------
Missing ` /* ReplacedWithOutlinedCall = */ ` on bool param?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106995/new/

https://reviews.llvm.org/D106995