[PATCH] D116702: [GlobalISel] Combine select + fcmp to fminnum/fmaxnum/fminimum/fmaximum

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:5423-5424
+    return false;
+  // Signed zero may return inconsistent results between implementations.
+  //  (0.0 <= -0.0) ? 0.0 : -0.0 // Returns 0.0
+  //  minNum(0.0, -0.0)          // May return -0.0 or 0.0 (IEEE 754-2008 5.3.1)
----------------
The 0 behavior is specified as ordering -0<0 for FMAXIMUM/FMINIMUM


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:5457
+  };
+  errs() << "applied\n";
+  return true;
----------------
Leftover debug printing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116702/new/

https://reviews.llvm.org/D116702