[PATCH] D116698: [CMake] Disable LLVM_INCLUDE_GO_TESTS by default

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 13:40:10 PST 2022


MaskRay created this revision.
MaskRay added reviewers: aaron.ballman, aeubanks, pcc.
Herald added a subscriber: mgorny.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

llvm/test/Bindings/Go is quite flaky in the past few months and nobody fixes it.

See

- https://lists.llvm.org/pipermail/llvm-dev/2021-December/154353.html "Suggestions on debugging pre-merge test failure that looks irrelevant."
- https://github.com/llvm/llvm-project/issues/53017


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116698

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -593,7 +593,7 @@
 option(LLVM_BUILD_TESTS
   "Build LLVM unit tests. If OFF, just generate build targets." OFF)
 option(LLVM_INCLUDE_TESTS "Generate build targets for the LLVM unit tests." ON)
-option(LLVM_INCLUDE_GO_TESTS "Include the Go bindings tests in test build targets." ON)
+option(LLVM_INCLUDE_GO_TESTS "Include the Go bindings tests in test build targets." OFF)
 
 option(LLVM_BUILD_BENCHMARKS "Add LLVM benchmark targets to the list of default
 targets. If OFF, benchmarks still could be built using Benchmarks target." OFF)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116698.397700.patch
Type: text/x-patch
Size: 682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220105/993ae4b3/attachment.bin>


More information about the llvm-commits mailing list