[PATCH] D111416: [Demangle] Add minimal support for D simple basic types

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 13:11:08 PST 2022


ljmf00 added a comment.

@dblaikie I removed all the uncovered types and added just minimal support just to prove type parsing functionality. I change the name of the patch to reflect the changes. I still have `Demangled << "int";` and `Demangled << "void";` that are covered but with untested behaviour. I can add a comment explaining why or remove it completely if you prefer.



================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:450
+  case 'O': /* shared(T) */
+    Mangled++;
+    Decl->append("shared(");
----------------
MaskRay wrote:
> Prefer pre-increment `++Mangled` (https://llvm.org/docs/CodingStandards.html#prefer-preincrement)
Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111416/new/

https://reviews.llvm.org/D111416



More information about the llvm-commits mailing list